News Feed
Jobs Feed
Sections




News Archive
Looking for more information on how to do PHP the right way? Check out PHP: The Right Way

Lars Strojny's Blog:
Antipattern the verbose constructor
July 31, 2008 @ 10:29:14

In this new post from Lars Strojny, there's a discussion of an "antipattern" - using the constructor for more than it was intended, the "verbose constructor".

Constructors are often used to shortcut dependency injection and parameter passing on instantiation. This is a valid practice and often leads to shorter code. [...] Instead of creating a new instance of "Money" and calling three setter, everything can be done compactly in the constructor. [...] So for the money object this works pretty well. The code is easy to read, but wait, the first argument can be grasped easily, the second too, but the third? It is not too obvious that it is a divisor is passed.

He compares three different ways to get the data into the class - the already-mentioned parameters in the constructor, passing an array into the constructor and using full getters/setters to push the data into the right places (with fluent interfaces even!).

1 comment voice your opinion now!
antipattern verbose constructor array getter setter


blog comments powered by Disqus

Similar Posts

Setfive.com: PHP: Some thoughts on using array_* with closures

Freek Lijten's Blog: Currently on PHP's internals...

Maggie Nelson's Blog: How to (and how not to) pass an array from PHP to the database

Lorna Mitchell's Blog: PHP and JSON

Allan MacGregor: Playing with dependency injection in PHP


Community Events











Don't see your event here?
Let us know!


introduction application podcast package release opinion composer hhvm framework security component code hack performance unittest language series facebook install symfony2

All content copyright, 2014 PHPDeveloper.org :: info@phpdeveloper.org - Powered by the Solar PHP Framework